Editing Hacking:Making pull requests

Jump to: navigation, search

Warning: The database has been locked for maintenance, so you will not be able to save your edits right now. You may wish to copy and paste your text into a text file and save it for later.

The system administrator who locked it offered this explanation: Upgrading to MediaWiki 1.31

The edit can be undone. Please check the comparison below to verify that this is what you want to do, and then save the changes below to finish undoing the edit.
Latest revision Your text
Line 29: Line 29:
 
[[File:Workflow mercurial.png|center]]
 
[[File:Workflow mercurial.png|center]]
 
* As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging.   
 
* As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging.   
βˆ’
* Normally you are not allowed create your named branch with name except '''develop'''. Instead you will use so called anonymous heads, see [http://stevelosh.com/blog/2009/08/a-guide-to-branching-in-mercurial/ a Guide to Branching in Mercurial]. In short a name of a named branch show us developing process only, we don't care contains it issue ticket number or not. Named branches only for long term task specific changes.
+
* Normally you are not allowed create named branch with name except '''feature'''. Instead you will use so called anonymous heads, see [http://stevelosh.com/blog/2009/08/a-guide-to-branching-in-mercurial/ a Guide to Branching in Mercurial]. In short a name of a named branch show us developing process only, we don't care contains it issue ticket number or not. Named branches only for long term task specific changes.
 
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help.
 
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help.
βˆ’
* Before starting committing your changes open your '''develop''' branch head. For this run command <code>hg branch -f develop</code>.
+
* Before starting committing your changes open your '''feature''' branch head. For this run command <code>hg branch -f feature</code>.
 
* Now you are ready to begin work. Make some changes and commit them with command <code>hg commit -m "Commit comment."</code>.
 
* Now you are ready to begin work. Make some changes and commit them with command <code>hg commit -m "Commit comment."</code>.
 
* When you are ready open new pull request. Please, read carefully official tutorial from Atlassian [https://www.atlassian.com/git/tutorials/making-a-pull-request Making a Pull Request]. This tutorial will help you understand how to work with bitbucket web site. '''But don't forget to return to this page and read it all. We have warned you.'''
 
* When you are ready open new pull request. Please, read carefully official tutorial from Atlassian [https://www.atlassian.com/git/tutorials/making-a-pull-request Making a Pull Request]. This tutorial will help you understand how to work with bitbucket web site. '''But don't forget to return to this page and read it all. We have warned you.'''
Line 37: Line 37:
 
* Don't forget to add your changes to file ChangeLog.txt. But only if these changes brings new feature or fix a bug. For example fixing building of the source code is not enough reason to update a changelog.
 
* Don't forget to add your changes to file ChangeLog.txt. But only if these changes brings new feature or fix a bug. For example fixing building of the source code is not enough reason to update a changelog.
 
* Don't need to close a named branch.
 
* Don't need to close a named branch.
βˆ’
* If you want to make several pull requests per time return to head develop/release branch and open another feature branch head. Repeat all previous steps.
+
* If you want to make several pull requests per time return to develop/release branch and open another feature branch head. Repeat all previous steps.
  
 
''Little bonus. You can find all successfully merged pull requests [https://bitbucket.org/dismine/valentina/pull-requests/?state=MERGED here]. These are good example if you want to find how look correctly made pull requests.''
 
''Little bonus. You can find all successfully merged pull requests [https://bitbucket.org/dismine/valentina/pull-requests/?state=MERGED here]. These are good example if you want to find how look correctly made pull requests.''

Please note that all contributions to Seamly2D are considered to be released under the Creative Commons Attribution Share Alike (see Seamly2D:Copyrights for details). If you do not want your writing to be edited mercilessly and redistributed at will, then do not submit it here.
You are also promising us that you wrote this yourself, or copied it from a public domain or similar free resource. Do not submit copyrighted work without permission!

Cancel | Editing help (opens in new window)